Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-toggle): clear name from host node #15668

Merged
merged 1 commit into from
May 13, 2019
Merged

fix(button-toggle): clear name from host node #15668

merged 1 commit into from
May 13, 2019

Conversation

crisbeto
Copy link
Member

Along the same lines as #15368. Since we forward the name to the underlying native inside a button toggle, otherwise the results from document.getElementsByName or Protractor's By.name might be thrown off.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 31, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 31, 2019 20:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 31, 2019
jelbourn
jelbourn approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 1, 2019
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jelbourn
Copy link
Member

@crisbeto this passes presubmit, just needs a rebase

@crisbeto
fix(button-toggle): clear name from host node
b8735c0 
Along the same lines as angular#15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.
@crisbeto
Copy link
Member Author

Rebased.

@jelbourn jelbourn merged commit 623cd06 into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
fix(button-toggle): clear name from host node (angular#15668)
9566cf4 
Along the same lines as angular#15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba